Ion density sampled evaluation #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer2368
force-pushed
the
pot-rom-online
branch
from
d0b48df
to
553fbb4
Compare
dreamer2368
changed the title
jeanlucf22
reviewed
Oct 8, 2024
dreamer2368
force-pushed
the
pot-rom-online
branch
from
3422054
to
efae443
Compare
jeanlucf22
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ion density evaluation on sampled grid points, for hyper-reduction of right-hand side of Hartree potential equation.
Potentials::evalIonDensityOnSamplePts,Potentials::initializeRadialDataOnSampledPtsevaluate ion density on specified sampled grid indices.Potentialsrescales byrescaleRhoCompand then adds background charge byaddBackgroundToRhoComp, ROM rescaling can be done only after hyper-reduction, thus these operations are skipped in this test.